Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs

Поиск

Список

Период

Сортировка

От	David G. Johnston
Тема	Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs
Дата	30 ноября 2020 г. 06:24:02
Msg-id	CAKFQuwbfhUx0dm-y__AkMHW6xVzRi0BQLQKGJePfyDisnsGPbg@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы	Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs
Список	pgsql-hackers

Дерево обсуждения

On Thu, Nov 26, 2020 at 12:49 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:

čt 26. 11. 2020 v 6:41 odesílatel David G. Johnston <david.g.johnston@gmail.com> napsal:
Hackers,

Bug # 16519 [1] is another report of confusion regarding trying to use parameters in improper locations - specifically the SET ROLE command within pl/pgsql. I'm re-attaching the doc patch and am adding it to the commitfest.

I checked this patch, and I think so it is correct - my comments are just about enhancing by some examples

Thank you for the review.

v2 attached.

I added examples in the two places you noted.

Upon re-reading, I decided that opening up the section by including everything then fitting in parameters with an exception for utility commands (without previously/otherwise identifying them) forced some undesirable verbosity. Instead, I opened up with the utility commands as the main body of non-result returning commands and then moved onto delete/insert/update non-returning cases when the subsequent paragraph regarding parameters can then refer to the second class (by way of excluding the first class). This seems to flow better, IMO.

David J.