Re: doc: Move enum storage commentary to top of section

Поиск
Список
Период
Сортировка
От David G. Johnston
Тема Re: doc: Move enum storage commentary to top of section
Дата
Msg-id CAKFQuwaCWPj7AGuARef65vNuY1gGOE-rY=Pijtka4Uj=yJjRZA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: doc: Move enum storage commentary to top of section  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Ответы Re: doc: Move enum storage commentary to top of section  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
Дерево обсуждения
On Wed, Jul 6, 2022 at 10:24 AM Matthias van de Meent <boekewurm+postgres@gmail.com> wrote:
On Thu, 9 Jun 2022 at 18:12, David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> Per suggestion over on -docs:
>
> https://www.postgresql.org/message-id/BL0PR06MB4978F6C0B69F3F03AEBED0FBB3C29@BL0PR06MB4978.namprd06.prod.outlook.com

I agree with moving the size of an enum into the top, but I don't
think that the label length documentation also should be included in
the top section. It seems excessively detailed for that section with
its reference to NAMEDATALEN.

-Matthias

Agreed.

Tangentially: It does seem a bit unusual to call the fact that the values both case-sensitive and limited to the length of a system identifier an implementation detail.  But if anything the length is more of one than the case-sensitivity.  Specifying NAMEDATALEN here seems like it breaks encapsulation, it could refer by comparison to an identifier and only those that care can learn how that length might be changed in a custom build of PostgreSQL.

David J.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Matthias van de Meent
Дата:
Сообщение: Re: doc: Move enum storage commentary to top of section
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: Custom tuplesorts for extensions