Re: CREATE TABLE .. LIKE .. EXCLUDING documentation

Поиск
Список
Период
Сортировка
От David G. Johnston
Тема Re: CREATE TABLE .. LIKE .. EXCLUDING documentation
Дата
Msg-id CAKFQuwa6o6EH6+RJhQLVSfwrnzfA9t7Bn9caFWcK_A-XGH+ykg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: CREATE TABLE .. LIKE .. EXCLUDING documentation  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: CREATE TABLE .. LIKE .. EXCLUDING documentation  (Yugo Nagata <nagata@sraoss.co.jp>)
Список pgsql-hackers
Дерево обсуждения
On Thu, Jun 28, 2018 at 3:57 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 27 Jun 2018, at 18:02, Yugo Nagata <nagata@sraoss.co.jp> wrote:

> I found that there isn't explanation about EXCLUDING in CREATE TABLE doc.
> Attached is a patch to add this. I would appreciate it if a native English
> speaker comments on this.

+      If <literal>EXCLUDING</literal> option <literal></literal> is specified

The empty <literal></literal> seems wrong.

+      after <literal>INCLUDING</literal> options, the specified thing is excluded

“thing” sounds a bit vague here (and in the last sentence as well), but I’m
also not sure what to use instead.  “referenced objects" perhaps?

+1 on documenting the EXCLUDING option though.

​"is excluded" and "not copied" are redundant to each other and the first sentence is basically redundant with the second.

​Maybe try something like:

It is legal to specify the same option multiple times - e.g., "INCLUDING option EXCLUDING option" - the outcome is whichever comes last in the command (i.e., in the example, option is excluded).

David J.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Fix to not check included columns in ANALYZE on indexes
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Fix to not check included columns in ANALYZE on indexes