Re: Typo Patch

Given that "curitem->qoperator.​distance" is constant.

Also, both loops go from low to high position (over the same scale)  with the inner loop stopping as soon as it moves beyond the position of the outer loop - namely that the left/inner item is always positioned to the left of the right/outer operand within the document being search.

Regardless of whether there is a match at this meeting point increasing the outer loop's position will not cause any of the previously checked (at the lower positions) inner loop items to match where they did not before.  I say this but I'm concerned that for sufficiently large values of curitem->qoperator.distance a given left operand could match multiple right operands since the distance is a maximum extent.

Thus, in the case of a match the current Lpos needs to be checked again during the subsequent iterator of the outer loop.

The "else if (Rpos - Lpos < distance) break" block though is oddly commented/written since distance is a maximum - shouldn't this be treated as a match as well?

Since, for sufficiently large values of "distance", a single left operand could cause multiple right operands to be matched when the less-than condition matches we need to leave Lpos alone and try the next Rpos against it.  For the greater than (default) and the equal cases we can skip rechecking the current Lpos.

The comment in question can be removed - we're not actually resetting anything here.  The use of LposStart is not really needed - just make sure to leave Lpos in the correct position (i.e. optional increment on all paths) and the inner while loop will do the correct thing.

It seems a bit odd to be keying off of the RIGHT operand and returning its position when left-to-right languages would consider the position of the leading word to be reported.

Code Comment Suggestion:

For each physically positioned right-side operand iterate over each instance of the left-side operand to locate one within the specified distance.  As soon as a match is found move onto the next right-operand and continue searching starting with the last checked left-side operand.  Note that for an exact distance match the current left-side operand can be skipped over.

For some graphical imagery consider how a Slinky operates.  Hold the left side, move the right side, release the left and let it collapse; repeat.  In this case, though, the collapsing can be stopped mid-stream since the distance check has an inequality.

The following shouldn't be taken as an actual patch submission but rather a codification of the above.