On Thu, Jan 17, 2019 at 5:15 AM Surafel Temesgen <surafel3000@gmail.com> wrote:
> On Fri, Jan 4, 2019 at 3:08 PM David Rowley <david.rowley@2ndquadrant.com> wrote:
>>
>> On Mon, 31 Dec 2018 at 18:58, Surafel Temesgen <surafel3000@gmail.com> wrote:
>>
>>
>> 2. Is --insert-multi a good name? What if they do --insert-multi=1?
>> That's not very "multi". Is --rows-per-insert better?
>>
>
> --rows-per-insert is better for me .
Some thoughts/suggestions:
+ int dump_inserts_multiple;
The option name uses rows, seems like this should mirror that and be
named "dump_inserts_max_rows"
+ <varlistentry>
+ <term><option>--rows-per-insert</option></term>
+ <listitem>
+ <para>
+ When using <option>--rows-per-insert</option>, this allows
the maximum number
+ of rows per <command>INSERT</command> statement to be specified.
+ </para>
+ </listitem>
+ </varlistentry>
"When using <repeat option name from 20 characters ago>..." - no other
option description uses this redundant language and this should not
either. Just say what it does.
This specifies the maximum number of rows (default 1) that will be
attached to each <command>INSERT</command> command generated by the
<option>--inserts</option> or <option>--column-inserts</option>
options; exactly one of which must be specified as well. (see my note
at the end)
+ printf(_(" --rows-per-insert number of row per INSERT
command\n"));
(maximum?) number of row[s] per INSERT command
+ qr/\Qpg_dump: option --on-conflict-do-nothing requires option
--inserts , --rows-per-insert or --column-inserts\E/,
+ 'pg_dump: option --on-conflict-do-nothing requires option --inserts
, --rows-per-insert or --column-inserts');
You don't put spaces on both sides of the comma, just after; and add a
comma before the "or" (I think...not withstanding the below)
I suggest we require that --rows-per-insert be dependent upon exactly
one of --inserts or --column-inserts being set and not let it be set
by itself (in which case the original message for
--on-conflict-do-nothing is OK).
David J.