Re: psql \dh: List High-Level (Root) Tables and Indexes
От | Greg Sabino Mullane |
---|---|
Тема | Re: psql \dh: List High-Level (Root) Tables and Indexes |
Дата | |
Msg-id | CAKAnmmKuLQ0J4HwT70kTPPUYSGzriuN7oOApky3NQWruW_mPiw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: psql \dh: List High-Level (Root) Tables and Indexes (Sadeq Dousti <msdousti@gmail.com>) |
Ответы |
Re: psql \dh: List High-Level (Root) Tables and Indexes
|
Список | pgsql-hackers |
The patch applies cleanly, and works as advertised. Nice work!
Quick notes:
In the varlistentry section, the order should be the same as the other places (N after m)
Line 1644 has an extra comma
Line 1651, maybe the example is simpler as \dNt to keep the wording better, because "indexes that are not partitions" looks odd.
These bits:
pg_log_error("Did not find any%s relations named \"%s\".",
no_partition_description, pattern);
are not good for translation. We want things simple with replaceable args/constants, but not replaceable words.
I think the myopt.title ones are fine.
* bin/psql/help.c:
\\dN[Sx+] [PATTERN] list relation, table, index (no partitions)
better as:
\\dN[Sx+] [PATTERN] list tables and indexes (no partitions)
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
В списке pgsql-hackers по дате отправления: