Re: Correction of RowMark Removal During Sel-Join Elimination
| От | Greg Sabino Mullane |
|---|---|
| Тема | Re: Correction of RowMark Removal During Sel-Join Elimination |
| Дата | |
| Msg-id | CAKAnmmJzSGzTRaLATNZPErByO3-j6MwsK--qPSiRLJi4kB05HQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Correction of RowMark Removal During Sel-Join Elimination (Andrei Lepikhov <lepihov@gmail.com>) |
| Ответы |
Re: Correction of RowMark Removal During Sel-Join Elimination
|
| Список | pgsql-hackers |
Basic concept looks good. However:
I'm not convinced this is an improvement from someone just coming in to this part of the code, especially given (for example) the comment right above it:
* Determine if the inner table can duplicate outer rows. We must
* bypass the unique rel cache here since we're possibly using a
and fixes the incorrect behaviour. Additionally, it renames variables to make
similar errors more apparent in the future.
- if (!innerrel_is_unique_ext(root, joinrelids, inner->relids,
- outer, JOIN_INNER, selfjoinquals,
+ if (!innerrel_is_unique_ext(root, joinrelids, rrel->relids,
+ krel, JOIN_INNER, selfjoinquals,
I'm not convinced this is an improvement from someone just coming in to this part of the code, especially given (for example) the comment right above it:
* Determine if the inner table can duplicate outer rows. We must
* bypass the unique rel cache here since we're possibly using a
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
В списке pgsql-hackers по дате отправления: