Re: A question about code in DefineRelation()

Поиск
Список
Период
Сортировка
От Hadi Moshayedi
Тема Re: A question about code in DefineRelation()
Дата
Msg-id CAK=1=Wo2Cx4vsCFhiE8O3Be0F9fg70PedBnSPiqn=yofSbHMpw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: A question about code in DefineRelation()  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Ответы Re: A question about code in DefineRelation()  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Re: A question about code in DefineRelation()  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Список pgsql-hackers


On second thought I noticed that that makes CREATE FOREIGN TABLE include
an OID column in newly-created foreign tables wrongly, when the
default_with_oids parameter is set to on.  Please find attached a patch.


The fix makes sense to me, since in ALTER TABLE SET WITH OIDS we check that the relation is a table and not a foreign table:

3160 case AT_AddOids: /* SET WITH OIDS */
3161 ATSimplePermissions(rel, ATT_TABLE);

So, I think we should be consistent between DefineRelation() and alter table.

-- Hadi.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dmitry Dolgov
Дата:
Сообщение: Re: Json(b) extension
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Composite Datums containing toasted fields are a bad idea(?)