On Fri, Jan 11, 2019 at 11:05 AM Andres Freund <andres@anarazel.de> wrote:
Hi,
On 2018-12-19 14:21:29 -0500, Robert Haas wrote: > On Tue, Dec 18, 2018 at 11:17 PM Andres Freund <andres@anarazel.de> wrote: > > Another would be to be aggressive in renaming, and deconflict by > > renaming functions like heap_create[_with_catalog] etc to sound more > > accurate. I think that has some appeal, because a lot of those names > > aren't describing their tasks particularly well. > > I like that option.
I'd like to start doing that by moving the functions in the following heapam.h block elsewhere:
ISTM that the first block would best belong into new files like access/rel[ation].h and access/common/rel[ation].h. I think the second set should be renamed to be table_open() (with backward compat redirects, there's way way too many references) and should go into access/table.h access/table/table.c alongside tableam.[ch], but I could also see just putting them into relation.[ch].