On Thu, Jan 19, 2017 at 12:26 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> Patch 0001 and 0003 required to rebase on the latest head. 0002 is >> still the same. > > I've committed the first half of 0001. Thanks. 0001 and 0003 required rebasing after this commit.
I reviewed 0002-hash-support-alloc-free-v12.patch, some minor comments.
-SH_TYPE *tb;
-uint64size;
+SH_TYPE *tb;
+uint64 size;
The above change may not be required.
+if (tb->alloc)
+{
+tb->alloc->HashFree(tb->data, tb->alloc->args);
+pfree(tb->alloc);
+}
The above code tries to free the tb->alloc memory. In case if the user
has provide the alloc structure to SH_CREATE function and the same
pointer is stored in the tb structure. And in free function freeing that
memory may cause problem.
So either explicitly mentioning that the input must a palloc'ed data or
by default allocate memory and copy the input data into allocated