Re: Logical Replication of sequences

Поиск
Список
Период
Сортировка
От shveta malik
Тема Re: Logical Replication of sequences
Дата
Msg-id CAJpy0uCPuTLEkuC7kbXwvyUuxrtKOhDb9A3ti6EhOKgzMNkbcQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Logical Replication of sequences  (shveta malik <shveta.malik@gmail.com>)
Список pgsql-hackers
Please find a few comments on 003:

1)
+#include "replication/logicallauncher.h"
+#include "replication/origin.h"
+#include "replication/slot.h"

syncutils.c compiles without these 3 inclusions.

2)
Should 'table_states_not_ready' be changed to
'relation_states_not_ready' as now it handles both tables and
sequences?

3)
invalidate_syncing_table_states has been changed to
InvalidateRelationStates. Shall we keep it as
InvalidateSyncingRelStates()?

4)
getSubscriptionTables:

- *   Get information about subscription membership for dumpable tables. This
+ *   Get information about subscription membership for dumpable relations. This

Is there a reason that we have changed the comment but not the function name?

thanks
Shveta



В списке pgsql-hackers по дате отправления: