Re: Unexpected Standby Shutdown on sync_replication_slots change

On Tue, Aug 5, 2025 at 10:38 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Mon, Aug 4, 2025 at 5:29 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Sat, Aug 2, 2025 at 1:28 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> > > This fix does feel more like an enhancement to user feedback and
> > > safety nets, not a correction of a broken or unsafe code path. Unable
> > > to start up with the same settings for it might cause
> > > more-than-necessary surprise.
> >
> > Agreed.
> >
> > At first, since there seems to be rough consensus on applying the current patch
> > (which prevents unexpected shutdown while the server is running),
> > I've pushed it to master and back-patched it to v17.
> >
> > As for the follow-up change that prevents the server from starting with
> > an invalid configuration, let's continue the discussion. I've attached
> > the patch and agree it's a good fit for master.
>
> +1. The patch looks good.
>
> > However, I'm afraid
> > it's too late to include it in v18, as beta2 has already been released
> > and this change is more of an improvement than a bug fix.
> >
>
> If it's not possible to get it to v18 now, then I am okay to have it
> on master alone.
>

Just wanted to confirm, do we plan to do it on master at-least?

thanks
Shveta