Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS

Поиск
Список
Период
Сортировка
От Matheus de Oliveira
Тема Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS
Дата
Msg-id CAJghg4KVqcEDVMQYYv7+zy1B2t8D2-F+m+QTsnxPOukKy27QWA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Ответы Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ONSCHEMAS  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Список pgsql-hackers
Дерево обсуждения

On Mon, Jan 9, 2017 at 10:58 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Also, should I add translations for that error message in other languages (I
> can do that without help of tools for pt_BR) or is that a latter process in
> the releasing?
>

I think you should add it but i am not sure when it is done.


I'll ask one of the guys who work with pt_BR translations (I know him in person).

 
> Other than that, I added a few regression tests (similar to others used for
> ADP), and patched the documentation (my English is not that good, so I'm
> open to suggestions). Anything else I forgot?

You have forgot to change the description section of "ADP". In the
description section you need to mention that privileges for schemas
too can be altered along with other database objects.

Oh... Indeed an oversight, thanks for pointing that out.

 
Other than that,
I feel the patch looks good and has no bug.

Attached a rebased version and with the docs update pointed by Ashutosh Sharma.

Best regards,
--
Matheus de Oliveira


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Fetter
Дата:
Сообщение: Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATEand DELETE
Следующее
От: David Fetter
Дата:
Сообщение: Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATEand DELETE