Re: WIP: a way forward on bootstrap data

Поиск
Список
Период
Сортировка
От John Naylor
Тема Re: WIP: a way forward on bootstrap data
Дата
Msg-id CAJVSVGX1WbYtnE_2LNrf8dpz_O2bOOh37RjYXcbACaxPH=H68Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: WIP: a way forward on bootstrap data  (John Naylor <jcnaylor@gmail.com>)
Ответы Re: WIP: a way forward on bootstrap data
Re: WIP: a way forward on bootstrap data
Список pgsql-hackers
I wrote:

> On 3/21/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I've got mixed feelings about the whitespace lines between fields.  They
>> seem like they are mostly bulking up the code and we could do without
>> 'em.
>> On the other hand, pgindent will insist on putting one before any
>> multi-line field comment, and so that would create inconsistent
>> formatting
>> if we don't use 'em elsewhere.  Thoughts?
>
> I'll do it both ways for one header and post the results for people to look
> at.

I've attached an earlier version of pg_proc.h with both formats as I
understand them. I turned a couple comments into multi-line comments
to demonstrate. I think without spaces it's just as hard to read as
with multiple annotations. I'd vote for spaces, but then again I'm not
the one who has to read these things very often.

-John Naylor

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: WIP: a way forward on bootstrap data
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: [PATCH] Verify Checksums during Basebackups