Re: Review of pg_archivecleanup -x option patch

Поиск
Список
Период
Сортировка
От Jaime Casanova
Тема Re: Review of pg_archivecleanup -x option patch
Дата
Msg-id CAJKUy5i8Otnb7QvT0HwjaWt5-aUbrZXqh+HD4z1caud706Do_Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Review of pg_archivecleanup -x option patch  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Review of pg_archivecleanup -x option patch
Список pgsql-hackers
On Thu, Mar 8, 2012 at 8:25 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sun, Feb 12, 2012 at 9:19 PM, Greg Smith <greg@2ndquadrant.com> wrote:
>> The smaller step of automatically stripping the specified suffix from the
>> input file name, when it matches the one we've told the program to expect,
>> seems like a usability improvement unlikely to lead to bad things though.
>>  I've certainly made the mistake you've shown when using the patched version
>> of the program myself, just didn't think about catching and correcting it
>> myself before.  We can rev this to add that feature and resubmit easily
>> enough, will turn that around soon.
>
> This change seems plenty small enough to slip in even at this late
> date, but I guess we're lacking a new version of the patch.
>

Sorry, here's the patch rebased and with the suggestion from Alex.
Which reminds me, I never thank him for the review (shame on me) :D

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql_fdw, FDW for PostgreSQL server
Следующее
От: Jaime Casanova
Дата:
Сообщение: Re: Review of pg_archivecleanup -x option patch