On Mon, 25 May 2020 at 22:01, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, May 25, 2020 at 06:29:10PM +0900, Michael Paquier wrote:
> > Perhaps you are right though, and that we don't need to spend this
> > much energy into improving the error messages so I am fine to discard
> > this part. At the end, in order to remove the crashes, you just need
> > to keep around the two RELKIND_HAS_STORAGE() checks. But I would
> > rather keep these two to use ereport(ERRCODE_FEATURE_NOT_SUPPORTED)
> > instead of elog(), and keep the test coverage of the previous patch
> > (including the tests for the aggregates I noticed were missing).
> > Would you be fine with that?
>
> And this means the attached. Thoughts are welcome.
so, currently the patch just installs protections on both currtid_*
functions and adds some tests... therefore we can consider it as a bug
fix and let it go in 13? actually also backpatch in 12...
patch works, server doesn't crash anymore
only point to mention is a typo (a missing "l") in an added comment:
+ * currtid_byrename
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services