Re: [pgAdmin][RM6581] [React] Port Language node to react

Поиск
Список
Период
Сортировка
От Pradip Parkale
Тема Re: [pgAdmin][RM6581] [React] Port Language node to react
Дата
Msg-id CAJ9T6SuoAeh7TOtxk8fT0SY3Oy1pLpkgz=U0nAjeyXK14szWwg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM6581] [React] Port Language node to react  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin][RM6581] [React] Port Language node to react  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Akshay,

Please find the updated patch.

On Fri, Jul 9, 2021 at 5:13 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Pradip

Following are the review comments:
  • The language name is not visible for the existing language in the properties panel as well as dialog.
Fixed. 
  • The "Trusted?" switch is showing the wrong value for the 'plpgsql' language in the properties panel as well as dialog.
Fixed. 
  • Unable to provide custom language names as we did before this patch.
Fixed. 
  • All the controls on the "Definition" tab are always disabled, also values are not getting populated for existing language.
Fixed. 
  • Improve the code coverage to 80%, currently, it is 72.13%
Fixed, improved to 78%. 

On Thu, Jul 8, 2021 at 7:22 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6581: [React] Port Language node to react

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][Patch] - Housekeeping #6584 - [React] Port Collation node to react
Следующее
От: Fahar Abbas
Дата:
Сообщение: Re: pgAdmin4 v5.5 candidate builds