Hi,
> >> IMO a test is needed that makes sure no one is going to break this in
> >> the future.
> >
> > You definitely need more complex test scenarios for that. If you can
> > come up with new ways to make the TAP tests of pg_rewind mode modular
> > in handling more complicated node setups, that would be a nice
> > addition, for example.
>
> I'm sorry for lacking tests. For now, I started off with a simple test
> that cause the problem I mentioned. The updated WIP patch 0001 includes
> the new test for pg_rewind.
Many thanks for a quick update.
> And also, I'm afraid that I'm not sure what kind of tests I have to make
> for fix this behavior. Would you mind giving me some advice?
Personally I would prefer not to increase the scope of work. Your TAP
test added in 0001 seems to be adequate.
> BTW, I was able to
> reproduce the assertion failure Kuwamura-san reported, even after applying
> your latest patch from the thread.
Do you mean that the test fails or it doesn't but there are other
steps to reproduce the issue?
--
Best regards,
Aleksander Alekseev