Re: Wrong usage of pqMsg_Close message code?

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: Wrong usage of pqMsg_Close message code?
Дата
Msg-id CAJ7c6TPYi5cvMpptYhr+DqBhPcVhciAG-n9kxBro_Q5=NXbY7w@mail.gmail.com
обсуждение исходный текст
Ответ на Wrong usage of pqMsg_Close message code?  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: Wrong usage of pqMsg_Close message code?
Список pgsql-hackers
Дерево обсуждения 
Hi Pavel,

> There is message PqMsgClose, but this should be used from client side. Here should be used PqMsg_CommandComplete
instead?

It seems so. This change was introduced in f4b54e1ed98 [1]:

```
--- a/src/backend/tcop/dest.c
+++ b/src/backend/tcop/dest.c
@@ -176,7 +176,7 @@ EndCommand(const QueryCompletion *qc, CommandDest
dest, bool force_undecorated_o

                        len = BuildQueryCompletionString(completionTag, qc,

                  force_undecorated_output);
-                       pq_putmessage('C', completionTag, len + 1);
+                       pq_putmessage(PqMsg_Close, completionTag, len + 1);

                case DestNone:
                case DestDebug
```

It should have been PqMsg_CommandComplete.

[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f4b54e1ed98

-- 
Best regards,
Aleksander Alekseev

В списке pgsql-hackers по дате отправления: