Re: Missing NULL check after calling ecpg_strdup

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: Missing NULL check after calling ecpg_strdup
Дата
Msg-id CAJ7c6TPHq8=w6H7V+A_=veenFrjQFqVTAyK7bgweX9PL2ko9_w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Missing NULL check after calling ecpg_strdup  (Aleksander Alekseev <aleksander@tigerdata.com>)
Ответы Re: Missing NULL check after calling ecpg_strdup
Список pgsql-hackers
Hi,

> While working on it I noticed a potentially problematic strcmp call,
> marked with XXX in the patch. I didn't address this issue in v2.

Here is the corrected patch v3. Changes since v2:

```
                for (con = all_connections; con != NULL; con = con->next)
                {
-                       /* XXX strcmp() will segfault if con->name is NULL */
-                       if (strcmp(connection_name, con->name) == 0)
+                       /* Check for NULL to prevent segfault */
+                       if (con->name != NULL &&
strcmp(connection_name, con->name) == 0)
                                break;
                }
                ret = con;
```

I was tired or something and didn't think of this trivial fix.

As a side note it looks like ecpg could use some refactoring, but this
is subject for another patch IMO.



В списке pgsql-hackers по дате отправления: