Hi,
> A comment about v3-0001.
>
> - * If true, use long segment filenames formed from lower 48 bits of the
> - * segment number, e.g. pg_xact/000000001234. Otherwise, use short
> - * filenames formed from lower 16 bits of the segment number e.g.
> - * pg_xact/1234.
> + * If true, use long segment filenames. Use short filenames otherwise.
> + * See SlruFileName().
>
> We're losing some details here even if SlruFileName() has some
> explanations, because one would need to read through the snprintf's
> 04X to know that short file names include 4 characters. I'm OK to
> mention SlruFileName() rather than duplicate the knowledge here, but
> SlruFileName() should also be updated to mention the same level of
> details with some examples of file names.
Fair enough. Here is the updated patchset.
--
Best regards,
Aleksander Alekseev