Hi Nikita,
Thanks for working on this.
> master:
> [...]
> Time: 47.346 ms
>
> patched:
> [...]
> Time: 7.607 ms
Looks impressive. I believe there is still some room for improvement though:
1. IMO the new API (create_detoast_iterator et al) should have
corresponding unit tests.
2. Suggestion: perhaps (entity)_(action) naming would be better, that
is: detoast_iterator_create(), detoast_iterator_free() etc.
3. If you could demonstrate that there is no performance degradation
for other scenarios that would be great.
--
Best regards,
Aleksander Alekseev