Re: [PATCH] Remove unused #include's in src/backend/commands/*
От | Aleksander Alekseev |
---|---|
Тема | Re: [PATCH] Remove unused #include's in src/backend/commands/* |
Дата | |
Msg-id | CAJ7c6TO5cRvaLjNj4hdf8i+rSc27+7pDcLRtan4BQSE3wvr=Fw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Remove unused #include's in src/backend/commands/* (Andres Freund <andres@anarazel.de>) |
Ответы |
Re: [PATCH] Remove unused #include's in src/backend/commands/*
|
Список | pgsql-hackers |
Hi Andres, > Manually analyze each of the removed includes by hand. Fix all the issues that > lead to iwyu giving you wrong suggestions. Well, I did, and played it as safe as I could in fact. Unfortunately given the amount of (build systems * supported hardware * supported operating systems * OS versions * build flags * #ifdefs in the code * compilers) this is a difficult problem to reason about, for both people and IWYU. > Test it with CI in your own repo. I see your point. I thought I tested the patch good enough locally to make it pass on cfbot the first time, but clearly I was wrong. If cfbot will complain again I'll continue experimenting with the patch in my own repository. Thanks for your feedback and apologies for the noise on the mailing list. It was not intended. -- Best regards, Aleksander Alekseev
В списке pgsql-hackers по дате отправления: