Dear David,
On Mon, Dec 12, 2022 at 1:50 PM David Rowley <dgrowleyml@gmail.com> wrote:
> I've attached the v11 set of patches.
Thanks for creating the v11 version. I think your patches look good to
me. I really apologize for my late reply.
> a) I think the iterator code should have some additional sanity checks
> that the results of both methods match when building with
> USE_ASSERT_CHECKING. I've got some concerns that we might break
> something. The logic about what the em_relids is set to for child
> members is a little confusing. See add_eq_member().
I added sanity checking code to check that two iteration results are
the same. I have attached a new version of the patch, v12, to this
email.
The implementation of my sanity checking code (v12-0004) is not ideal
and a little ugly. I understand that and will try to improve it.
However, there is more bad news. Unfortunately, some regression tests
are failing in my environment. I'm not sure why, but it could be that
a) my sanity checking code (v12-0004) is wrong, or b) our patches have
some bugs.
I will investigate this issue further, and share the results when found.
--
Best regards,
Yuya Watari