Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

Поиск
Список
Период
Сортировка
От Shubham Khanna
Тема Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Дата
Msg-id CAHv8RjL4mWy9LUu1Ufat4ojqbf5bZEFkPcxN1B0ASC5-w=qvaA@mail.gmail.com
обсуждение исходный текст
Ответ на RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Ответы Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Список pgsql-hackers
On Mon, Mar 3, 2025 at 5:59 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Shubham,
>
> I did a quick check and have a comment in drop_publication().
>
> ```
> +       /* For cleanup purposes */
> +       dbinfos.dbinfo->made_publication = true;
> +
> ```
>
> Please do not modify randomly. Currently, made_publication is set to false when
> the command fails. No need to set to true here - Please follow that. Also, please
> do not remove comments within the if statement.
>

Fixed the suggested changes. The attached patch contains the required changes.

Thanks and regards,
Shubham Khanna.

Вложения

В списке pgsql-hackers по дате отправления: