On Thu, Dec 3, 2020 at 5:34 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> While looking at the patch set I found that the tests in
> src/test/subscription don't work with this patch. I got the following
> error:
>
> 2020-12-03 15:18:12.666 JST [44771] tap_sub ERROR: unrecognized
> pgoutput option: two_phase
> 2020-12-03 15:18:12.666 JST [44771] tap_sub CONTEXT: slot "tap_sub",
> output plugin "pgoutput", in the startup callback
> 2020-12-03 15:18:12.666 JST [44771] tap_sub STATEMENT:
> START_REPLICATION SLOT "tap_sub" LOGICAL 0/0 (proto_version '2',
> two_phase 'on', publication_names '"tap_pub","tap_pub_ins_only"')
>
> In v29-0009 patch "two_phase" option is added on the subscription side
> (i.g., libpqwalreceiver) but it seems not on the publisher side
> (pgoutput).
>
The v29-0009 patch is still a WIP for a new SUBSCRIPTION "two_phase"
option so it is not yet fully implemented. I did run following prior
to upload but somehow did not see those failures yesterday:
cd src/test/subscription
make check
Anyway, as 0009 is the last of the set please just git apply
--reverse that one if it is causing a problem.
Sorry for any inconvenience. I will add the missing functionality to
0009 as soon as I can.
Kind Regards,
Peter Smith.
Fujitsu Australia