Re: Skipping schema changes in publication
От | Peter Smith |
---|---|
Тема | Re: Skipping schema changes in publication |
Дата | |
Msg-id | CAHut+Pvb-gNmqAi=mtai9riN+61P_KiC8PT3AFi+CLRxXH9HRg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Skipping schema changes in publication (Peter Smith <smithpb2250@gmail.com>) |
Список | pgsql-hackers |
> > > 5. > > > + <para> > > > + Alter publication <structname>mypublication</structname> to add table > > > + <structname>users</structname> except column > > > + <structname>security_pin</structname>: > > > +<programlisting> > > > +ALTER PUBLICATION production_publication ADD TABLE users EXCEPT (security_pin); > > > > > > Those tags don't seem correct. e.g. "users" and "security_pin" are not > > > <structname> (???). > > > > > > Perhaps, every other example here is wrong too and you just copied > > > them? Anyway, something here looks wrong to me. > > > > > I saw different documents and usage of tags seems not well defined. > > For example for table we are using tags in document > > create_publication.sgml, update.sgml <structname> is used, in document > > table.sgml, advanced.sgml <classname> is used, and in > > logical-replication.sgml <literal> is used. Similarly for column > > names <structname>, <structfield> or <literal> are used in different > > parts of the document. > > > > I kept the changed tag to <structfield> for the column for this patch. > > Do you have any suggestions? > > No, for this patch I think it is best that you just follow nearby code > (as you are already doing). I plan to raise another thread to ask what > are the guidelines for this sort of markup which is currently used > inconsistently in different places. > FYI - I created a new thread asking this markup question [1]. ====== [1] https://www.postgresql.org/message-id/CAHut%2BPvtf24r%2BbdPgBind84dBLPvgNL7aB%2B%3DHxAUupdPuo2gRg%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
В списке pgsql-hackers по дате отправления: