Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
От | Peter Smith |
---|---|
Тема | Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description |
Дата | |
Msg-id | CAHut+PvSQWG-m6wUfoQfnShTXDAjoa3-MhNQ=_N3GBM31g1Vbw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description ("David G. Johnston" <david.g.johnston@gmail.com>) |
Список | pgsql-hackers |
On Mon, Sep 9, 2024 at 12:20 PM David G. Johnston <david.g.johnston@gmail.com> wrote: > > > > On Sun, Sep 8, 2024, 18:55 Peter Smith <smithpb2250@gmail.com> wrote: >> >> Saying "The time..." is fine, but the suggestions given seem backwards to me: >> - The time this slot was inactivated >> - The time when the slot became inactive. >> - The time when the slot was deactivated. >> >> e.g. It is not like light switch. So, there is no moment when the >> active slot "became inactive" or "was deactivated". > > > While this is plausible the existing wording and the name of the field definitely fail to convey this. > >> >> Rather, the 'inactive_since' timestamp field is simply: >> - The time the slot was last active. >> - The last time the slot was active. > > > I see your point but that wording is also quite confusing when an active slot returns null for this field. > > At this point I'm confused enough to need whatever wording is taken to be supported by someone explaining the code thatinteracts with this field. > Me too. I created this thread primarily to get the description changed to clarify this field represents a moment in time, rather than a duration. So I will be happy with any wording that addresses that. > I suppose I'm expecting something like: The time the last activity finished, or null if an activity is in-progress. ====== Kind Regards, Peter Smith. Fujitsu Australia
В списке pgsql-hackers по дате отправления: