Re: walsender.c comment with no context is hard to understand

Поиск
Список
Период
Сортировка
От Peter Smith
Тема Re: walsender.c comment with no context is hard to understand
Дата
Msg-id CAHut+PukgSkO=mA8-dcSVXyTGGFaus0eZjOL0gacwQzMQ1UpHw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: walsender.c comment with no context is hard to understand  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: walsender.c comment with no context is hard to understand
Список pgsql-hackers
Дерево обсуждения 
On Fri, Jun 28, 2024 at 4:18 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
...
> Shouldn't the check for flushptr (if (flushptr < targetPagePtr +
> reqLen)) be moved immediately after the call to WalSndWaitForWal().
> The comment seems to suggests the same: "Make sure we have enough WAL
> available before retrieving the current timeline. .."

OK, I have changed the code as suggested. Please see the attached v2 patch.

make check-world was successful.

======
Kind Regards,
Peter Smith.
Fujitsu Australia
Вложения

В списке pgsql-hackers по дате отправления: