Re: Skip collecting decoded changes of already-aborted transactions

Поиск
Список
Период
Сортировка
От Peter Smith
Тема Re: Skip collecting decoded changes of already-aborted transactions
Дата
Msg-id CAHut+Pu8Eqc35OmK_uaC=NFtqOn=bVhrYvVrcJ_ewBkcZx77+g@mail.gmail.com
обсуждение исходный текст
Ответ на Skip collecting decoded changes of already-aborted transactions  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: Skip collecting decoded changes of already-aborted transactions
Список pgsql-hackers
Hi. Here are some minor comments for the v18* patch set.

//////////

Patch v18-0001

1.1. Commit message

A previously reported typo still exists:

/noticeble/noticeable/

//////////

Patch v18-0002

2.1
+#define RBTXN_PREPARE_STATUS_FLAGS (RBTXN_IS_PREPARED |
RBTXN_SKIPPED_PREPARE | RBTXN_SENT_PREPARE)
+

AFAICT bitmasks like this are more commonly named with a _MASK suffix.

How about something like:
- RBTXN_PREPARE_MASK
- RBTXN_PREPARE_STATUS_MASK
- RBTXN_PREPARE_FLAGS_MASK

==========
Kind Regards,
Peter Smith.
Fujitsu Australia



В списке pgsql-hackers по дате отправления: