typedef struct LogicalDecodingContext

Поиск
Список
Период
Сортировка
Искать
От
Peter Smith
Тема
typedef struct LogicalDecodingContext
Дата
Msg-id
CAHut+PtfFphZxBYBA8fa7Sq8wAMRCqGBuaR9gCdfCNbPR7E2gA@mail.gmail.com
Список
Дерево обсуждения
typedef struct LogicalDecodingContext Peter Smith <smithpb2250@gmail.com>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Peter Smith <smithpb2250@gmail.com>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: typedef struct LogicalDecodingContext Peter Smith <smithpb2250@gmail.com>
Re: typedef struct LogicalDecodingContext Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct LogicalDecodingContext Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Hi,

During a recent code review, I noticed a lot of 'struct
LogicalDecodingContext' usage.

There are many function prototypes where the params are (for no
apparent reason to me) a mixture of structs and typedef structs.

AFAICT just by pre-declaring the typedef struct
LogicalDecodingContext, all of those 'struct LogicalDecodingContext'
can be culled, resulting in cleaner and more consistent function
signatures.

The PG Docs were similarly modified.

PSA patch for this.  It passes make check-world.

(I recognize this is potentially the tip of an iceberg. If this patch
is deemed OK, I can hunt down similar underuse of typedefs for other
structs)

Thoughts?

------
Kind Regards,
Peter Smith.
Fujitsu Australia
В списке pgsql-hackers по дате отправления
От: Heikki Linnakangas
Дата:
От: Joseph Koshakow
Дата:
Сообщение: Re: Infinite Interval
FAQ