Hi, here are some review comments for v19-0002
======
src/backend/replication/logical/tablesync.c
make_copy_attnamelist:
nitpick - tweak function comment
nitpick - tweak other comments
~~~
fetch_remote_table_info:
nitpick - add space after "if"
nitpick - removed a comment because logic is self-evident from the variable name
======
src/test/subscription/t/004_sync.pl
1.
This new test is not related to generated columns. IIRC, this is just
some test that we discovered missing during review of this thread. As
such, I think this change can be posted/patched separately from this
thread.
======
src/test/subscription/t/011_generated.pl
nitpick - change some comment wording to be more consistent with patch 0001.
======
99.
Please see the nitpicks diff attachment which implements any nitpicks
mentioned above.
======
Kind Regards,
Peter Smith.
Fujitsu Australia