Re: [pgadmin-hackers][Patch] Refactor sql template version picking

Поиск
Список
Период
Сортировка
От George Gelashvili
Тема Re: [pgadmin-hackers][Patch] Refactor sql template version picking
Дата
Msg-id CAHowoHbgRM-fwxBqwUCcKUr=UKih5hhec=GP2OPf3byzQS-_ng@mail.gmail.com
обсуждение исходный текст
Ответ на [pgadmin-hackers][Patch] Refactor sql template version picking  (George Gelashvili <ggelashvili@pivotal.io>)
Ответы Re: [pgadmin-hackers][Patch] Refactor sql template version picking  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
As a followup, we created this additional patch removing now-redundant sql templates. If you're interested in how we decided what files to delete, the script we used is here. We only removed files that were exactly identical between multiple postgres versions for the same feature.

This patch should be applied on a master patched with version-aware-sql-template-loader-refactor.diff


On Thu, Jan 26, 2017 at 12:22 PM, George Gelashvili <ggelashvili@pivotal.io> wrote:
Hi Hackers!

Since we are preparing to add greenplum support, we made a new template loader to automatically pick the available sql template file that corresponds to the postgres version number.

Our next patch will be to remove duplicated sql template files since many of the files are identical between versions.

Cheers,
George & Tira

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Jan Alexander Steffens
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup
Следующее
От: George Gelashvili
Дата:
Сообщение: Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)