On Tue, Jan 12, 2016 at 5:50 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> Error and Fatal exception classes are introduced in my patch - it was Peter'
> request (if I remember it well), and now I am thinking so it is not good
> idea.
Now everybody is confused :). Your patch does:
- PLy_exc_error = PyErr_NewException("plpy.Error", NULL, NULL);
- PLy_exc_fatal = PyErr_NewException("plpy.Fatal", NULL, NULL);
- PLy_exc_spi_error = PyErr_NewException("plpy.SPIError", NULL, NULL);
[snip]
+ PLy_exc_error = PyErr_NewException("plpy.Error", PLy_exc_base, NULL);
+ PLy_exc_fatal = PyErr_NewException("plpy.Fatal", PLy_exc_base, NULL);
+ PLy_exc_spi_error = PyErr_NewException("plpy.SPIError",
PLy_exc_base, NULL);
So they are there without the patch, you now make them inherit from
the new BaseError previously they just inherited from Exception.
More soon in another reply I was just typing when this came in.