Richard Guo <guofenglinux@gmail.com> writes: > Not related to this issue but I wonder why blkno is verified after > the relation is opened. It can be verified beforehand, no?
It makes sense to me to check the parameters left-to-right, so I think verifying blkno after relation is fine. It's not like there's value in optimizing the failure case.
This does, however, suggest that we ought to check the relkind immediately after opening the rel, before the blkno check. I'll adjust the patch that way and push.