On Wed, Apr 09, 2025 at 05:43:24PM +0300, Heikki Linnakangas wrote: > Agreed. I use both, depending on which mood I'm in.
Same here, extended to OidIsValid(), HeapTupleIsValid(), XLogRecPtr, etc., and I tend to prefer such macros, except if consistency of the surroundings matter most. FWIW, I think that living with the current state of things to limit backpatch pain is fine. There is no need to change the existing code as an attempt to apply more standardization even if one or more code grammar patterns mean the same thing.