Re: Suggestion to add --continue-client-on-abort option to pgbench

On Wed, Oct 29, 2025 at 1:00 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Mon, Oct 27, 2025 at 6:13 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> > One approach to address this issue is to keep calling PQgetResult() until
> > it returns NULL, and then check the connection status when getSQLErrorStatus()
> > determines the error state. If the connection status is CONNECTION_BAD
> > at that point, we can treat it as a connection failure and stop processing
> > even when --continue-on-error is specified. Attached is a WIP patch
> > implementing this idea based on the v17 patch. It still needs more testing,
> > review, and possibly documentation updates.
> >
> > Another option would be to explicitly list all SQLSTATE codes (e.g., 57P01)
> > that should prevent continued processing, even with --continue-on-error,
> > inside getSQLErrorStatus(). However, maintaining such a list would be
> > cumbersome, so I believe the first approach is preferable. Thought?
>
> Nagata-san let me know off-list that there was the case where the previous
> patch didn't work correctly in pipeline mode. I've updated the patch so that
> --continue-on-error now works properly in that mode, and also revised
> the commit message. Updated patch attached.

In v19 patch, the description of --continue-on-error was placed right after
--verbose-errors in the docs. Since pgbench long option descriptions are listed
in alphabetical order, I've moved it to follow --aggregate-interval instead.
I've also refined the wording of the --continue-on-error description.

Attached is the updated patch. Unless there are any objections, I will
commit it.

Regards,

--
Fujii Masao