On Sun, Jun 29, 2014 at 11:18 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2014-06-29 19:44:21 +0530, Abhijit Menon-Sen wrote:
>> At 2014-06-27 00:51:02 +0200, petr@2ndquadrant.com wrote:
>> >
>> > Also based on Alvaro's comment, I replaced the scanf parsing code with
>> > strtoul(l) function.
>>
>> As far as I can tell (from the thread and a quick look at the patch),
>> your latest version of the patch addresses all the review comments.
>>
>> Should I mark this ready for committer now?
>
> Well, we haven't really agreed on a way forward yet. Robert disagrees
> that the feature is independently useful and thinks it might be
> dangerous for some users. I don't agree with either of those points, but
> that doesn't absolve the patch from the objection. I think tentatively
> have been more people in favor, but it's not clear cut imo.
So what's the usecase of this feature? If it's for "normal operation",
using pg_resetxlog for that is a bit dangerous because it can corrupt
the database easily.
Regards,
--
Fujii Masao