On Thu, Nov 22, 2012 at 9:38 PM, Amit kapila <amit.kapila@huawei.com> wrote:
> Patch to implement SET PERSISTENT command is attached with this mail.
> Now it can be reviewed.
I got the following compile warnings:
xact.c:1847: warning: implicit declaration of function
'AtEOXact_UpdateAutoConfFiles'
guc.c:5134: warning: enumeration value 'PGC_ENUM' not handled in switch
"SET PERSISTENT name TO value" failed, though "SET PERSISTENT name = value"
succeeded.
=# SET PERSISTENT synchronous_commit TO 'local';
ERROR: syntax error at or near "TO"
LINE 1: SET PERSISTENT synchronous_commit TO 'local';
=# SET PERSISTENT synchronous_commit = 'local';
SET
SET PERSISTENT succeeded even if invalid setting value was set.
=# SET PERSISTENT synchronous_commit = 'hoge';
SET
SET PERSISTENT syntax should be explained by "\help SET" psql command.
When I remove postgresql.auto.conf, SET PERSISTENT failed.
=# SET PERSISTENT synchronous_commit = 'local';
ERROR: failed to open "postgresql.auto.conf" file
We should implement "RESET PERSISTENT"? Otherwise, there is no way
to get rid of the parameter setting from postgresql.auto.conf, via SQL. Also
We should implement "SET PERSISTENT name TO DEFAULT"?
Is it helpful to output the notice message like 'Run pg_reload_conf() or
restart the server if you want new settings to take effect' always after
SET PERSISTENT command?
Regards,
--
Fujii Masao