Re: Support for REINDEX CONCURRENTLY

On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I have been working on improving the code of the 2 patches:
> 1) reltoastidxid removal:
<snip>
> - Fix a bug with pg_dump and binary upgrade. One valid index is necessary
> for a given toast relation.

Is this bugfix related to the following?
    appendPQExpBuffer(upgrade_query,
-                      "SELECT c.reltoastrelid, t.reltoastidxid "
+                      "SELECT c.reltoastrelid, t.indexrelid "                      "FROM pg_catalog.pg_class c LEFT
JOIN"
 
-                      "pg_catalog.pg_class t ON (c.reltoastrelid = t.oid) "
-                      "WHERE c.oid = '%u'::pg_catalog.oid;",
+                      "pg_catalog.pg_index t ON (c.reltoastrelid = t.indrelid) "
+                      "WHERE c.oid = '%u'::pg_catalog.oid AND t.indisvalid "
+                      "LIMIT 1",

Don't indisready and indislive need to be checked?

Why is LIMIT 1 required? The toast table can have more than one toast indexes?

Regards,

-- 
Fujii Masao