Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

Поиск
Список
Период
Сортировка
От Euler Taveira
Тема Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Дата
Msg-id CAH503wC=abvOL4o_w=GwTH2uHbXtcrm=eh-ZWOSLAAnUUaB1VA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Andres Freund <andres@anarazel.de>)
Ответы Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Дерево обсуждения
On Thu, 12 Mar 2020 at 16:25, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2020-03-12 14:08:31 +0800, Craig Ringer wrote:
>
> I thought about that at first, but that'll only benefit people who're
> hand-compiling things, and it's already possible with
>
>     make with_llvm=no ...

Well, the difference is that you'd be told about it, instead of getting
a hard to parse error message.

What about adding a WARNING but don't error out if LLVM isn't found? Add an additional option (if LLVM isn't found) is annoying because it means adding instruction into README of all extensions. What is the side effects of not providing .bc files? It seems some extensions won't benefit from LLVM.
 

Regards,

--
Euler Taveira                 http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Berserk Autovacuum (let's save next Mandrill)
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [PATCH] Skip llvm bytecode generation if LLVM is missing