Re: [HACKERS] Adding support for Default partition in partitioning

Поиск
Список
Период
Сортировка
От Rahila Syed
Тема Re: [HACKERS] Adding support for Default partition in partitioning
Дата
Msg-id CAH2L28uiYH=16Uxu5Zo_fRyS3hhj_rSD7JqTsnPwyKgdiF=-Rw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Adding support for Default partition in partitioning  (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>)
Список pgsql-hackers
Дерево обсуждения
Hello Jeevan,

Thank you for comments.

I will include your comments in the updated patch.

>7.The output of describe needs to be improved.

The syntax for DEFAULT partitioning is still under discussion. This comment wont be
applicable if the syntax is changed.

>6.
>I am wondering, isn't it possible to retrieve the has_default and default_index
>here to find out if default partition exists and if exist then find it's oid
>using rd_partdesc, that would avoid above(7) loop to check if partition bound is
>default
The checks are used to find the default partition bound and
exclude it from the list of partition bounds to form the partition constraint.
This cant be accomplished by using has_default flag.
isDefaultPartitionBound() is written to accomplish that.


>8.
>Following call to find_inheritance_children() in generate_qual_for_defaultpart()
>is an overhead, instead we can simply use an array of oids in rd_partdesc.
I think using find_inheritance_children() will take into consideration concurrent
drop of a partition which the value in rd_partdesc will not.

Thank you,
Rahila Syed


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: [HACKERS] Foreign Join pushdowns not working properly for outerjoins
Следующее
От: Nikhil Sontakke
Дата:
Сообщение: Re: [HACKERS] StandbyRecoverPreparedTransactions recovers subtranslinks incorrectly