Re: BUG #19367: typos in backend/utils/adt/timestamp.c

Поиск
Список
Период
Сортировка
От Rahila Syed
Тема Re: BUG #19367: typos in backend/utils/adt/timestamp.c
Дата
Msg-id CAH2L28tGUhoH21j_+RP9X0g=s=G0NmuMYxOKZKSspamvEe3i-Q@mail.gmail.com
обсуждение исходный текст
Ответ на BUG #19367: typos in backend/utils/adt/timestamp.c  (PG Bug reporting form <noreply@postgresql.org>)
Список pgsql-bugs
Hi,

There are typos in return type of these functions:
1) timestamptz_pl_interval_at_zone(PG_FUNCTION_ARGS)
    NOW: PG_RETURN_TIMESTAMP(timestamptz_pl_interval_internal(timestamp,
span, attimezone));
    SHOULD:
PG_RETURN_TIMESTAMPTZ(timestamptz_pl_interval_internal(timestamp, span,
attimezone));
2) Datum timestamptz_mi_interval_at_zone(PG_FUNCTION_ARGS)
    NOW: PG_RETURN_TIMESTAMP(timestamptz_mi_interval_internal(timestamp,
span, attimezone));
    SHOULD:
PG_RETURN_TIMESTAMPTZ(timestamptz_mi_interval_internal(timestamp, span,
attimezone));


You’re right — these are just typos, and they don’t affect correctness since both
ultimately call Int64GetDatum().
Still, +1 for fixing them for clarity.

Thank you,
Rahila Syed

В списке pgsql-bugs по дате отправления: