Re: Add pg_get_injection_points() for information of injection points
От | Rahila Syed |
---|---|
Тема | Re: Add pg_get_injection_points() for information of injection points |
Дата | |
Msg-id | CAH2L28tDJSb3eF=dU_LWAS6qM3Ta2u4U5sezOT1Qdtbswwdirw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Add pg_get_injection_points() for information of injection points (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: Add pg_get_injection_points() for information of injection points
|
Список | pgsql-hackers |
Hi Michael,
Thank you for the updated patches.
> Would it be useful to put the logic of the above function under #define
> USE_INJECTION_POINT. This approach would make it possible to
> distinguish between cases where no injection points are attached and
> instances where the build does not support injection points.
For this one, I've found that InjectionPointList() was the incorrect
bit: we can make it issue an elog(ERROR) if !USE_INJECTION_POINTS.
This way, none of its callers will be confused between the case of a
NIL List meaning either !USE_INJECTION_POINTS or that there are no
points attached if the build uses USE_INJECTION_POINTS.
The changes LGTM.
Should the execution privileges on the function be restricted to a role like pg_monitor?
Thank you,
Rahila Syed
В списке pgsql-hackers по дате отправления: