Re: new heapcheck contrib module

On Fri, Oct 23, 2020 at 11:51 AM Tom Lane  wrote:
>             /* Set up context information about this next tuple */
>             ctx.lp_len = ItemIdGetLength(ctx.itemid);
>             ctx.tuphdr = (HeapTupleHeader) PageGetItem(ctx.page, ctx.itemid);
>             ctx.natts = HeapTupleHeaderGetNatts(ctx.tuphdr);
>
> with absolutely no thought for the possibility that lp_off is out of
> range or not maxaligned.  The checks for a sane lp_len seem to have
> gone missing as well.

That is surprising. verify_nbtree.c has PageGetItemIdCareful() for
this exact reason.

-- 
Peter Geoghegan