On Fri, Apr 26, 2019 at 4:57 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> ItemId[Data] is somewhat less widely referenced, but I'm still not
> much in favor of renaming that type. I think fixing comments to
> uniformly call it an item ID would be more reasonable. (We should
> leave the "line pointer" terminology in place, too; if memory serves,
> an awful lot of variables of the type are named "lp" or variants.
> Renaming all of those is to nobody's benefit.)
I was proposing that we not rename any struct at all, and continue to
call ItemId[Data]s "line pointers" only. This would involve removing
the comment in itemid.h that confusingly refers to line pointers as
"item pointers" (plus any other comments that fail to make a clear
distinction).
I think that the total number of comments that would be affected by
this approach is quite low.
--
Peter Geoghegan