Re: Pathify RHS unique-ification for semijoin planning

Поиск
Список
Период
Сортировка
От wenhui qiu
Тема Re: Pathify RHS unique-ification for semijoin planning
Дата
Msg-id CAGjGUAKwL-Z4WTZ6C89yXnTeUjGp9v8pPEZx54se=229x_RRow@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Pathify RHS unique-ification for semijoin planning  (Richard Guo <guofenglinux@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Richard
    Thanks for your feedback. I agree this approach is better for keeping the code style consistent.


Thanks

On Fri, Aug 8, 2025 at 9:39 AM Richard Guo <guofenglinux@gmail.com> wrote:
On Thu, Aug 7, 2025 at 6:04 PM wenhui qiu <qiuwenhuifx@gmail.com> wrote:
> In light of this commit (https://github.com/postgres/postgres/commit/e035863c9a04beeecc254c3bfe48dab58e389e10), I also recommend changing the macro to a static inline function. Macros are harder to debug and lack type safety.

I'm inclined not to do that.  We already have other macros for
checking whether a relation is of a certain kind, and I'd prefer to
keep the new check consistent with those.

Thanks
Richard

В списке pgsql-hackers по дате отправления: