Re: [PATCH] Little refactoring of portalcmds.c

Поиск
Список
Период
Сортировка
От wenhui qiu
Тема Re: [PATCH] Little refactoring of portalcmds.c
Дата
Msg-id CAGjGUAJJCO0cYA297226epqwfj+UutGnYUigng9riApJo+pm=Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Little refactoring of portalcmds.c  (Quan Zongliang <quanzongliang@yeah.net>)
Список pgsql-hackers
Дерево обсуждения
Hi Aleksander Alekseev
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO. 
I  agree with your suggestion to refactor the duplicated code into a function.

Thanks 

On Mon, Oct 27, 2025 at 2:03 PM Quan Zongliang <quanzongliang@yeah.net> wrote:


On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
>
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
>

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang



В списке pgsql-hackers по дате отправления:

Чтобы сделать работу с сайтом удобнее, мы используем cookie и аналитический сервис «Яндекс.Метрика». Продолжая пользоваться сайтом, вы соглашаетесь с их использованием.