Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

Поиск
Список
Период
Сортировка
От Mahi Gurram
Тема Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)
Дата
Msg-id CAGg=Gufv9iP2uJHzNVOqsmthuM2NK=6SS4ciioT8at7g1vg5JA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)  (Thomas Munro <thomas.munro@enterprisedb.com>)
Ответы Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Thomas,
 
If your plan is to write a preloaded library, then I think your
_PG_init() function needs to register a callback with
shmem_startup_hook.  See pgss_shmem_startup for an example.  You may
need to set up a piece of traditional named shared memory that
backends can use to find either (1) the handle for your DSA area or
(2) your DSA area itself (if you use the 'in place' constructor), and
also allocate and share a lock tranche number.

Followed the same as per your suggestion. Refer the code snippet below:

void
_PG_init(void){
RequestAddinShmemSpace(100000000);
        PreviousShmemHook = shmem_startup_hook;
       shmem_startup_hook = BufferShmemHook;
}
void BufferShmemHook(){
dsa_area *area;
dsa_pointer data_ptr;
        char *mem;
  area = dsa_create(my_tranche_id());
       data_ptr = dsa_allocate(area, 42);
       mem = (char *) dsa_get_address(area, data_ptr);
       if (mem != NULL){
           snprintf(mem, 42, "Hello world");
       }
        bool found;
shmemData = ShmemInitStruct("Mahi_Shared_Data",
  sizeof(shared_data),
  &found);
shmemData->shared_area = area;
shmemData->shared_area_handle = dsa_get_handle(area);
shmemData->shared_data_ptr = data_ptr;
        shmemData->head=NULL;
}

Wrote one UDF function, which is called by one of the client connection and that tries to use the same dsa. But unfortunately it is behaving strange.

First call to my UDF function is throwing segmentation fault and postgres is quitting and auto restarting. If i try calling the same UDF function again in new connection(after postgres restart) it is working fine.

Put some prints in postgres source code and found that dsa_allocate() is trying to use area->control(dsa_area_control object) which is pointing to wrong address but after restarting it is pointing to right address and hence it is working fine after restart.

I'm totally confused and stuck at this point. Please help me in solving this.

PS: It is working fine in Mac.. in only linux systems i'm facing this behaviour.
 
I have attached the zip of my extension code along with screenshot of the pgclient and log file with debug prints for better understanding.
*logfile is edited for providing some comments for better understanding.

Please help me in solving this.

Awaiting your response.

Thanks & Best Regards,
- Mahi


On Sat, May 27, 2017 at 7:53 PM, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
On Tue, May 23, 2017 at 10:42 PM, Mahi Gurram <teckymahi@gmail.com> wrote:
> Hello everyone,
>
> I'm building In-Memory index extension for Postgres, for which i'm trying to
> use DSA. But ended with some issues, as it is not allowing me to create
> DSA(Dynamic Shared Area) in _PG_init function.
>
> Please refer my_PG_init code below:
>>
>> void
>> _PG_init(void)
>> {
>> area = dsa_create(LWLockNewTrancheId(), "CustomIndex_DSA");
>> area_handle = dsa_get_handle(area);
>> }
>
>
> Because of this code, Postgres is not starting. Not even giving any error
> messages in pg logs. Hence, i'm totally clue less :(
>
>
> Please let me know how to proceed. Your help is highly appreciated.

Hi Mahi

If your plan is to write a preloaded library, then I think your
_PG_init() function needs to register a callback with
shmem_startup_hook.  See pgss_shmem_startup for an example.  You may
need to set up a piece of traditional named shared memory that
backends can use to find either (1) the handle for your DSA area or
(2) your DSA area itself (if you use the 'in place' constructor), and
also allocate and share a lock tranche number.

Another approach would be to create the DSA area on demand (ie the
first time you need it for your new index feature), if you don't want
to have to preload the library, but there is a small problem with
that, at least in theory.  You probably still need to use a small bit
of named traditional shmem for discovery purposes, and it's slightly
against the rules to do that when you haven't called
RequestAddinShmemSpace, and it's too late to do that.

--
Thomas Munro
http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Mengxing Liu"
Дата:
Сообщение: [HACKERS] [GSOC] [Weekly report 2] Eliminate O(N^2) scaling from rw-conflicttracking in serializable transactions
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: [HACKERS] [GSOC] [Weekly report 2] Eliminate O(N^2) scaling fromrw-conflict tracking in serializable transactions