Re: Resetting recovery target parameters in pg_createsubscriber

Поиск
Список
Период
Сортировка
От Alyona Vinter
Тема Re: Resetting recovery target parameters in pg_createsubscriber
Дата
Msg-id CAGWv16JR45Kz6TPBEUMZH0nVp6ew2FGA4w74cumyT7HYMHKd6g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Resetting recovery target parameters in pg_createsubscriber  (Alyona Vinter <dlaaren8@gmail.com>)
Ответы Re: Resetting recovery target parameters in pg_createsubscriber
Список pgsql-hackers
Hi,

CFbot indicated some issues with the patch. I've attached rebased versions of the patches, so hopefully everything will be ok this time.

Best regards,
Alyona Vinter

On Fri, 5 Sept 2025 at 12:51, Alyona Vinter <dlaaren8@gmail.com> wrote:
Dear Hayato, 

Thank you for the review! My apologies for the error in the patch -- it looks like I accidentally modified it before sending =(. I've attached the fixed versions below. 

> Regarding patch content, your patch restores the postgresql.auto.conf after the
> command runs. Initially I felt that it is enough to set below GUCs becasue only
> they are changed from the default. Is there a reason why you fully restore them?

I just found it easier to restore the original state of 'postgresql.auto.conf', as removing parameters from the file resets them to their default values. This approach achieves the same final state without having to explicitly set each one.
Вложения

В списке pgsql-hackers по дате отправления: